REVIEW 3 major objections 6 minor 17 references
Secant Line Search for Frank-Wolfe Algorithms
T0 review · 3 major / 6 minor · reviewed 2026-08-09 · deepseek-v4-flash
Pith's one-line read A secant-method step-size rule gives Frank-Wolfe algorithms exact-line-search performance at low cost.
desk verdict Practical and well-tested idea, but Theorem 3.1 is false as stated: the clipping bug in Algorithm 2 can make the inner loop diverge, and the curvature assumption of Lemma 2.1 is not implied by strict convexity. read the letter →
The pith
A machine-rendered reading of the paper's core claim, the machinery that carries it, and where it could break.
The reading
What carries the argument
The working object is the directional derivative $\varphi(\gamma)=\langle\nabla f(\mathbf{x}_t-\gamma\mathbf{d}_t),\mathbf{d}_t\rangle$ along the Frank-Wolfe direction, whose zero is the optimal step size. SLS updates $\gamma_{n+1}=\gamma_n-\varphi(\gamma_n)(\gamma_n-\gamma_{n-1})/(\varphi(\gamma_n)-\varphi(\gamma_{n-1}))$, clipping to $[0,\gamma_{\max}]$. The load-bearing lemma, Lemma 2.1, guarantees monotone convergence to the root when $|\varphi'|$ strictly increases with distance from the root, a condition the proof of Theorem 3.1 derives from strict convexity of $f$; the paper also notes that the secant method converges superlinearly, with order $(1+\sqrt5)/2\approx1.618$, for simple roots, and in one iteration for quadratics.
What would settle it
Run the SLS loop on a strictly convex smooth function chosen so that $\varphi(\gamma)$ has a root but $|\varphi'(\gamma)|$ is not increasing in distance from it, with $\gamma_0=0$ and a tiny $\gamma_1$; if the secant iterates converge to a different point, oscillate, or leave the interval, Theorem 3.1's universality claim fails. A concrete candidate is a one-dimensional strictly convex function with an oscillating third derivative along the search direction, and the functions used in the paper's portfolio or optimal-design instances are natural places to look.
Extended reading notes
Core claim
On its own terms, the paper's central discovery is that the classical secant method, usually only locally convergent, becomes globally convergent when used as a line search inside Frank-Wolfe, because the feasible step is confined to $[0,\gamma_{\max}]$ and the root of the directional derivative is bracketed by the geometry of the algorithm. Theorem 3.1 asserts that for strictly convex smooth $f$ and compact convex $X$, the Frank-Wolfe iterates with SLS behave exactly as if an exact line search were used (up to a tolerance $\epsilon$), and each inner secant loop converges.
Load-bearing premise
The load-bearing premise is that along each search direction the absolute slope of the directional derivative increases with distance from the optimal step and that the two starting guesses, $\gamma_0=0$ and $\gamma_1=\rho$, lie on the same side of it; strict convexity alone does not force this, and the required size of $\rho$ is left unspecified.
Editorial extensions
If this is right
- Any Frank-Wolfe variant that uses a line search can substitute SLS without changing its convergence rate, including away-step, pairwise, and blended pairwise conditional gradients.
- For convex quadratic objectives, each SLS call converges in a single iteration, making SLS comparable in cost to the standard short-step rule while requiring no Lipschitz constant and exploiting local smoothness.
- The warm-started version of SLS reuses the previous optimal step, further cutting inner iterations to around one on average in the reported experiments.
- On generalized self-concordant objectives, the paper expects superlinear convergence of the inner secant iterations whenever the relevant third derivative is nonzero, giving high-precision step sizes in very few evaluations.
Reading between the lines
- The same bracketing argument might transfer SLS to other constrained descent methods whose steps live in a bounded interval and whose update direction is a feasible descent direction; the paper itself only claims this for Frank-Wolfe variants.
- A quantitative bound on "$\rho$ small" would turn Theorem 3.1 into a checkable initialization rule; the paper leaves the perturbation unspecified.
- The curvature-growth condition in Lemma 2.1 may hold for broader function classes than strict convexity; if verified, SLS would apply beyond smooth convex optimization.
- SLS's low inner-iteration count suggests it could be paired with inexact linear oracles, where the cost of solving the direction subproblem dominates and the line search becomes nearly free.
Editorial analysis
A structured set of objections, weighed in public.
Referee Report
Summary. The paper introduces Secant Line Search (SLS), a step-size rule for Frank-Wolfe (FW) algorithms that applies the secant method to the scalar equation φ(γ) = ⟨∇f(x_t − γd_t), d_t⟩ = 0 arising from exact line search, with iterates clipped to the interval [0, γ_max]. The main theoretical result, Theorem 3.1, claims that for strictly convex and smooth f over a compact convex set, every SLS inner call converges and the FW algorithm inherits its exact-line-search convergence rate. The supporting analysis consists of Lemma 2.1 (monotone convergence of the unclipped secant method under a curvature-growth condition), a local superlinear convergence discussion, an informal inexact-line-search rate appendix, and an extensive numerical study over quadratic, OED, portfolio, and matrix optimization instances implemented in FrankWolfe.jl.
Significance. The proposed strategy is well motivated: if the convergence guarantee were correct, SLS would provide a cheap, adaptive alternative to exact line search that often needs only one or two inner gradient evaluations, and the experimental section is a real asset. The paper ships reproducible experiments in an established open-source package, compares against several standard step-size rules, and reports competitive wall-clock performance on most problem classes. The standalone Lemma 2.1 is essentially correct under its stated curvature-growth hypothesis. However, the central claim linking SLS to FW is not established: Theorem 3.1's proof does not verify the lemma's hypothesis, and Algorithm 2, as written, can fail to terminate on simple instances where the unconstrained line-search root lies outside the feasible interval. Since the paper's headline contribution is precisely this guarantee, the numerical results, however extensive, cannot compensate for the failure of the theory.
major comments (3)
- [§2.1 (Lemma 2.1) and §3 (Theorem 3.1)] Lemma 2.1 requires |φ′(x)| to be strictly increasing in |x − a|, but the proof of Theorem 3.1 verifies only that φ is strictly monotone (from strict convexity of f) and then asserts that the assumptions of Lemma 2.1 are satisfied; this is a genuine gap. Strict convexity gives φ′(γ) = −d_tᵀ∇²f(x_t − γd_t)d_t < 0, which says nothing about the growth of |φ′| away from the root. For example, f(x) = x² − cos(x) is strictly convex and smooth on [0,1]; with x₀ = 0.1 and d₀ = x₀ − v₀ = 0.1, one has |φ′(γ)| = x₀²(2 + cos(x₀(1−γ))), which strictly decreases as γ moves away from the root γ_a = 1, so Lemma 2.1 does not apply even though the theorem's assumptions hold. The same-side initialization premise also requires ρ < γ_a, which is not quantified and can fail when the line-search root is very close to zero (e.g., near optimality); the theorem therefore proves neither the convergence of each SLS call nor the inherited FW rate.
- [Algorithm 2, lines 7–12] Algorithm 2's stopping rule is incompatible with the clipping in line 8. Lemma 2.1 analyzes the unclipped recurrence, whereas Algorithm 2 clips every candidate to [0, γ_max] and terminates only when |φ₀| < ε (line 12); if the unconstrained root of φ lies outside [0, γ_max], the constrained minimizer sits at the boundary, where φ does not vanish, so no iterate can satisfy the stopping rule. Concretely, for min_{x∈[0,1]} (x−10)² with x₀ = 0, d₀ = x₀ − v₀ = −1, and φ(γ) = 2(10−γ), the first secant step produces γ = 10, line 8 clips it to 1, and the loop recomputes φ(1) = 18 forever for any ε < 18. This contradicts the 'each SLS call converges' claim of Theorem 3.1 and the text's statement that clipping yields the constrained optimum; the fallback mentioned in Remark 4.1 is not implemented in Algorithm 2 or assumed in the theorem.
- [§3 and Appendix A] The claimed 'optimal rate' of FW under SLS is not actually quantified. Theorem 3.1 inherits the rate from exact line search 'up to the line search tolerance ε', but Appendix A, which is supposed to specify how FW rates depend on the line-search error, never defines the 'δ_t-minimizer' it uses and never connects the tolerance ε of Algorithm 2 (a condition on |φ|) to the δ_t entering (A.2). Since |φ(γ)| < ε alone does not bound f(x_t − γd_t) − min f on the segment without additional smoothness assumptions, the link between the implemented stopping rule and the claimed rate is missing; this is load-bearing because the theorem's first assertion is precisely the rate statement.
minor comments (6)
- [§2.1, Lemma 2.1] The statement that 'in particular a is the only root on U and φ is monotone on U' does not follow from the strict increase of |φ′| in |x−a| alone; monotonicity should be an explicit hypothesis (the remark following the lemma partially acknowledges this).
- [§3] The displayed definition 'φ(γ) = ⟨f(x_t − γd_t), d_t⟩' is missing the gradient operator and should read ⟨∇f(x_t − γd_t), d_t⟩; moreover, this φ is the negative of the derivative of the line-search objective, a sign convention worth stating explicitly.
- [Abstract and References] The abstract cites 'Pedregosa et al 2018', but the reference list gives Pedregosa et al. (2020); these should be aligned.
- [Remark 3.3] Remark 3.3 ends with the incomplete phrase 'by carrying out over the.'; the sentence should be completed or removed.
- [Remark 4.1 and Fig. 1] Remark 4.1: 'algorthmic' should read 'algorithmic', and the introduction's claim of 'around 6−7 iterations' for SLS should be reconciled with the average counts of roughly 1.5 reported in Fig. 1.
- [Appendix A, Eq. (A.2)] The displayed derivation in (A.2) uses overlapping struck-through and grouped terms that make the algebra difficult to follow; it should be typeset with explicit term-by-term grouping, and the assumption that line-search error enters through a δ_t term should be stated before the inequality.
Circularity Check
No significant circularity: the SLS convergence analysis is a self-contained root-finding argument, and the paper's self-citations are not load-bearing.
full rationale
The derivation chain is: define the secant recurrence for φ(γ)=⟨∇f(x_t−γd_t),d_t⟩; prove a standalone global-convergence lemma for the secant method (Lemma 2.1); then apply that lemma to the Frank-Wolfe line-search subproblem in Theorem 3.1. No fitted constants are renamed as predictions, no target result is embedded in the assumptions by construction, and no uniqueness or convergence guarantee is imported from a self-citation chain. The statement 'If SLS converges, then it returns the optimal solution to the line search problem' is a definitional reduction to exact line search, not a hidden equation equivalence: the paper still attempts to prove that SLS converges via Lemma 2.1. Self-citations such as FrankWolfe.jl, the OED benchmark, and prior FW step-size work appear in experiments and background, but the main theorem does not rest on them. The skeptical objection that strict convexity alone may not suffice for Lemma 2.1's monotonicity-of-|φ'| hypothesis, and that clipping in Algorithm 2 may conflict with the stopping rule, identifies a possible correctness gap, not circularity. Under the stated rules, correctness risks do not raise the circularity score.
Assumptions & free parameters
free parameters (2)
- rho (initial perturbation) =
unspecified; e.g., 1e-5
- line-search tolerance epsilon =
unspecified; reported as 1e-7 compatible with FW gap target
assumptions (4)
- domain assumption Strict convexity and smoothness of f, compact convex X
- ad hoc to paper Curvature-growth condition: |d_t^T Hess(f)(x_t - gamma d_t) d_t| is strictly increasing in distance from the line-search root
- ad hoc to paper Initial points gamma_0 and gamma_1 are on the same side of the root
- domain assumption Clipping to [0, gamma_max] does not prevent convergence of the secant iterates
Cite this review
Pith. "Pith review of Secant Line Search for Frank-Wolfe Algorithms." pith.science (2026). https://pith.science/paper/IK55JQ7D
@misc{pith2026250118775,
author = {Pith},
title = {Pith review of: Secant Line Search for Frank-Wolfe Algorithms},
year = {2026},
howpublished = {\url{https://pith.science/paper/IK55JQ7D}},
note = {Machine review of arXiv:2501.18775}
}
read the original abstract
We present a new step-size strategy based on the secant method for Frank-Wolfe algorithms. This strategy, which requires mild assumptions about the function under consideration, can be applied to any Frank-Wolfe algorithm. It is as effective as full line search and, in particular, allows for adapting to the local smoothness of the function, such as in Pedregosa et al 2018, but comes with a significantly reduced computational cost, leading to higher effective rates of convergence. We provide theoretical guarantees and demonstrate the effectiveness of the strategy through numerical experiments.
Figures
Figures from the paper (12 more)
Reference graph
Works this paper leans on
-
[1]
(A.3) If we choose constant δt =δ , the sum of the terms with δ on the right hand side becomes O(tδ)
i+ 2 + 1 At tX i=0 Aiδi < 2LD2 t+ 2 + 1 At tX i=0 Aiδi. (A.3) If we choose constant δt =δ , the sum of the terms with δ on the right hand side becomes O(tδ). So if we are aiming to get an ϵ-minimizer after T steps, we can choose T so that the first summand on the right hand side is ϵ/2 and we can choose δ= Θ(ϵ/T)so that the second summand isϵ/2afterTsteps...
work page 2022
-
[2]
Ill”. Well-conditioned quadratic problems denoted “QuadProb
Comparison of execution times between Secant and Newton’s methods for various test functions. Where f is explicitly provided, the gradient function is computed via automatic differentiation. For the line search problems, the gradient is provided directly and not computed via automatic differentiation, as those are instances extracted from the line search ...
work page 2020
-
[3]
Progress of the primal value and FW gap for two problems with a quadratic objective (nuclear norm and standard quadratic) and for two problems with a self-concordant objective (D-Opt and portfolio). In (a), the iterations and time are truncated at 10000 and 10 s, repectively, since Backtracking and Agnostic stall on this instance. Hendrych, D., Besançon, ...
work page 2024
-
[4]
C. Additional Experiments In this appendix, we provide additional information and context on the instance classes, and report more fine-grained results on experiments by problem class. Optimal Design of Experiment (OED).Optimal Design of Experiment is a problem maximizing an information criterion on the probability simplex and which was tackled by a FW me...
work page 2024
-
[7]
The geometric mean of the solving time is taken over all instances
Instances of the D-Optimal Experiment Design problem ordered by difficulty. The geometric mean of the solving time is taken over all instances. The geometric mean of the dual gap is only taken over instances that could not be solved up to the tolerance. The average number of iterations is taken over all solved instances. Brackets indicate that all instanc...
work page 1986
-
[8]
Schloss Dagstuhl – Leibniz-Zentrum für Informatik. ISBN 978-3-95977- 325-6. doi: 10.4230/LIPIcs.SEA.2024.16. URL https://drops.dagstuhl.de/entities/ document/10.4230/LIPIcs.SEA.2024.16. Jin, Q. and Mokhtari, A. Non-asymptotic superlinear conver- gence of standard quasi-Newton methods.Mathematical Programming, 200(1):425–473,
-
[10]
The geometric mean of the solving time is taken over all instances
Instances of the Spectrahedron problem ordered by difficulty. The geometric mean of the solving time is taken over all instances. The geometric mean of the dual gap is only taken over instances that could not be solved up to the tolerance. The average number of iterations is taken over all solved instances. Secant Adaptive Agnostic Backtracking Dim # Time...
-
[13]
0.5 <1e-7 284.6 1.44e-7 66 2083.7 2.09e-06 1263 166.8 3.63e-7 40 QuadProb
Show all 17 references
-
[14]
The geometric mean of the solving time is taken over all instances
Instances of the Birkhoff problem ordered by difficulty. The geometric mean of the solving time is taken over all instances. The geometric mean of the dual gap is only taken over instances that could not be solved up to the tolerance. The average number of iterations is taken ...
-
[15]
The geometric mean of the solving time is taken over all instances
Instances of the Ill-Conditioned Quadratic problem ordered by difficulty. The geometric mean of the solving time is taken over all instances. The geometric mean of the dual gap is only taken over instances that could not be solved up to the tolerance. The average number of ite...
-
[16]
We only included it here for completeness and since it is the textbook step-size rule for the vanilla Frank-Wolfe algorithm
as it does not work for generalized self-concordant functions (Carderera et al., 2021; 2024). We only included it here for completeness and since it is the textbook step-size rule for the vanilla Frank-Wolfe algorithm. Table
2021
-
[1970]
AdaBB: Adaptive Barzilai- Borwein method for convex optimization.arXiv preprint arXiv:2401.08024,
Zhou, D., Ma, S., and Yang, J. AdaBB: Adaptive Barzilai- Borwein method for convex optimization.arXiv preprint arXiv:2401.08024,
-
[2019]
W., Hassani, H., Karbasi, A., Mokhtari, A., and Pokutta, S
Braun, G., Carderera, A., Combettes, C. W., Hassani, H., Karbasi, A., Mokhtari, A., and Pokutta, S. Conditional gradient methods.arXiv preprint arXiv:2211.14103,
-
[2020]
and Mishchenko, K
Malitsky, Y . and Mishchenko, K. Adaptive proximal gra- dient method for convex optimization.arXiv preprint arXiv:2308.02261,
-
[2023]
Altschuler, J. M. and Parrilo, P. A. Acceleration by random stepsizes: Hedging, equalization, and the arcsine stepsize schedule.arXiv preprint arXiv:2412.05790, 2024a. Altschuler, J. M. and Parrilo, P. A. Acceleration by stepsize hedging: Silver stepsize schedule for smooth co...
-
[2024]
V ., Lessard, L., and Wilson, A
Cavalcanti, J. V ., Lessard, L., and Wilson, A. C. Adap- tive backtracking for faster optimization.arXiv preprint arXiv:2408.13150,
-
[2025]
Bolte, J., Combettes, C
URL https:// arxiv.org/abs/2501.14613. Bolte, J., Combettes, C. W., and Pauwels, E. The iterates of the Frank-Wolfe algorithm may not converge.Mathemat- ics of Operations Research, 49(4):2565–2578,
Reviewed August 9, 2026 · model on record in the stance chip above.
Discussion (0). Continue with ORCID to comment.