Pith. sign in

REVIEW 4 major objections 6 minor 31 references

Physics Of Eclipsing Binaries. IX. Spectroscopic module

T0 review · 4 major / 6 minor · reviewed 2026-08-06 · deepseek-v4-flash

Challenge this review Re-run · record.json Download PDF Read on arXiv ↗

Pith's one-line read The Phoebe code can now model stellar spectra triangle-by-triangle, including self-consistent eclipses.

desk verdict A solid, honest code paper for a new Phoebe spectroscopic module, with a real new capability in per-triangle spectral integration, but it needs observed validation and a calibration check before I'd trust absolute fluxes. read the letter →

arxiv 2506.20868 v1 pith:32555IF4 submitted 2025-06-25 astro-ph.SR astro-ph.IM

Miroslav Brož , Andrej Prša , Kyle E. Conroy , Michael Abdul-Masih This is my paper · ORCID
classification astro-ph.SRastro-ph.IM
keywords eclipsingbinariesspectroscopicmodelingsyntheticspectraPhoebelimbdarkeningspectralenergydistributionradialvelocitysurfaceintegration
verification ladder T0 review T1 audit T2 compute T3 formal

The pith

A machine-rendered reading of the paper's core claim, the machinery that carries it, and where it could break.

The reading

The paper describes a spectroscopic module for the Phoebe eclipsing-binary code that computes stellar spectra in either normalized or absolute flux units. The core claim is that by integrating synthetic spectra over the triangular surface mesh used for each star, the module treats eclipses, rotation, gravity darkening, and Doppler shifts self-consistently, so spectra can be fitted jointly with light curves and radial velocities. A simplified mode that sums one spectrum per component is fast but fails during eclipses, so the accurate integrate mode is intended for fitting. The authors demonstrate the module on synthetic examples but do not yet validate it against observed binary spectra. If it works as designed, it would let spectroscopy directly constrain temperatures, gravities, and metallicities of binary components instead of relying on light curves and radial velocities alone.

What carries the argument

The load-bearing machinery is the triangular surface mesh inherited from Phoebe, which follows the Roche potential. Each triangle carries local $T_{\rm eff}$, $\log g$, metallicity $Z$, surface area $S_i$, cosine angle $\cos\theta_i$, and a visibility fraction $f_i$. A synthetic spectrum is pulled from literature grids (resampled to 0.01 Å) and Doppler-shifted per the radial velocity of the triangle, then the normalized flux is $\Phi_\lambda = (1/L_{\rm tot})\sum_i I_{{\rm pass},i} S_i \cos\theta_i f_i I''_{\lambda,i}$, with analogous expressions for absolute SEDs. Limb darkening is applied analytically via user-supplied coefficients, and rotation and gravity darkening follow von Zeipel's law; the simplified mode applies rotational broadening with an FFT-based kernel. The interpolation engine Ndpolator handles non-uniform grids with nearest-neighbor extrapolation.

What would settle it

Compute a synthetic spectrum of a well-studied eclipsing binary with the integrate mode and compare it directly to an observed high-resolution spectrum taken mid-eclipse, where asymmetric line profiles test the surface integration; a separate check is to compare the SED near a grazing transit to a model that uses the full $\mu$-dependent intensity from the same synthetic grid, which would expose any limb-darkening mismatch.

Watch

Extended reading notes

Core claim

The central discovery is that a self-consistent spectroscopic model can be built on top of Phoebe's existing triangular-mesh description of stellar surfaces. For every visible triangle, a synthetic spectrum is interpolated from grids like PHOENIX, AMBRE, OSTAR, BSTAR, POLLUX, or POWR using local effective temperature, gravity, and metallicity; the spectrum is Doppler-shifted by the triangle's radial velocity; and the contributions are summed with limb-darkening and gravity-darkening weights. The same integration yields absolute fluxes (SEDs) when multiplied by surface area and divided by distance squared. The key result is that during an eclipse, the complex integrate model produces asymmetric line profiles from partially hidden surface regions, whereas a simplified per-component sum is wrong by factors up to 2. The approach extends to single stars, binaries, triples, and in principle to pulsating stars.

Load-bearing premise

The module assumes that the true limb darkening of each star is captured by a single analytical law with user-set coefficients, even though the synthetic spectra themselves encode a different limb darkening; if those coefficients are wrong or the law fits poorly, all absolute fluxes and any line profiles seen at high inclination or during eclipse will be systematically wrong.

Editorial extensions

If this is right

  • Joint fitting of light curves, radial velocities, spectra, and SEDs within a single code will better constrain masses, radii, temperatures, and distances of binary components.
  • Eclipse spectroscopy with the integrate mode can recover asymmetric line profiles that carry information about which parts of each star are hidden.
  • The simplified mode is fast enough for parameter scans but must be replaced by the integrate mode at and near eclipse phases.
  • The analytical limb-darkening approximation is presented as a workable compromise, since full $\\mu$-dependent grids would require four-dimensional data.
  • The module opens a path to fitting pulsations spectroscopically by perturbing surface radial velocities.

Reading between the lines

Editorial extensions of the paper, not claims the author makes directly.

  • If the module were validated against observed spectra of an eclipsing binary, the main risk is the analytical limb-darkening assumption: any mismatch would show up as a systematic flux or line-profile error that scales with inclination and eclipse depth.
  • One testable extension is to replace the analytical limb-darkening law with a precomputed function of local $\\mu$ derived from the same synthetic grids, which would remove the self-consistency gap at some memory cost.
  • The same surface-integration machinery could in principle synthesize spectra of exoplanet transits or circumbinary disks, since the integration over visible elements is generic.
Share X Bluesky LinkedIn Reddit HN

Editorial analysis

A structured set of objections, weighed in public.

Desk editor's note, referee report, and a circularity audit.

Referee Report

4 major / 6 minor

Summary. This paper describes a spectroscopic module for the PHOEBE binary-modeling code. The module can produce normalized and absolute spectra of single stars, binaries, and multiples by summing synthetic spectra over the triangular surface meshes already used for light-curve and radial-velocity modeling. Two modes are implemented: a 'complex' integrate mode with per-triangle spectra (Eqs. 3–8) and a 'simplified' mode with one spectrum per component (Eqs. 9–15). Synthetic spectra are taken from literature grids (PHOENIX, OSTAR, BSTAR, AMBRE, POLLUX, POWR), with Doppler shifts, rotational broadening, gravity darkening, and eclipse visibility handled. The paper presents several examples: complex versus simplified model comparison, solar flux calibration, limb darkening, rotation, and eclipse line asymmetries. The code is available in a development branch of the PHOEBE repository.

Significance. The module fills a practical gap in binary modeling: it allows joint fitting of spectra with light curves and radial velocities using the same surface-mesh geometry. The main strengths are the reuse of established synthetic spectral grids, the integration with PHOEBE's existing mesh machinery, the explicit per-triangle Doppler treatment, and the availability of the code and Jupyter notebooks. The solar calibration experiment is a useful sanity check. However, the paper currently validates the module only on synthetic examples; no observed binary spectrum is used, and the absolute flux calibration shows a 1.7% discrepancy that is not discussed. The limb-darkening approximation is acknowledged but not quantified. These issues weaken the support for the claim that the module can be used to fit observed spectra.

major comments (4)
  1. [Section 3.2] The solar flux calibration reports an integrated flux of 1338 W m^-2 versus the measured solar constant of 1360.8 ± 0.5 W m^-2 (Kopp & Lean 2011), a 1.7% offset. The paper does not state the wavelength integration limits used to obtain the 1338 value, nor does it discuss whether the offset arises from missing flux outside the plotted 2000–20000 Å range, from grid interpolation, or from the limb-darkening approximation. Since Eq. (8) provides the absolute SED mode intended for distance and radius estimation, this unquantified systematic offset needs to be addressed before the absolute-flux mode can be considered validated. At minimum, the integration limits and a realistic uncertainty estimate should be given.
  2. [Sections 2.1, 3.3, 3.5] The module uses synthetic spectra computed only for μ = 1 (Eq. 3 and the statement in §2.1 that interpolation is not done in μ), and limb darkening is imposed a posteriori through an analytical law; §3.3 explicitly calls this 'not self-consistent.' For the normalized-spectrum mode, every triangle contributes a line profile computed at μ = 1, so wavelength-dependent center-to-limb variations in line cores and wings are absent. The eclipse asymmetries presented in Fig. 7 therefore depend entirely on geometrical weights and the chosen analytical limb-darkening coefficients. The claim that the complex model 'correctly computes asymmetries' is not yet fully supported. I request a quantitative test—for example, comparison against a μ-resolved synthetic grid or against observed time-resolved eclipse spectra—to estimate the systematic error in line-profile shapes and absolute fluxes during partial phases.
  3. [Section 4 and throughout] The paper demonstrates the module only on synthetic examples; no observed spectrum of a star or binary is fitted or compared. Given the well-known systematics in spectral normalization, rectification, and calibration, which the authors themselves list in the Conclusions, a methods paper presenting a fitting module should include at least one observed single-star or binary spectrum test. Without such a test, the central claim that the module is suitable for joint fitting of observed spectra remains unverified.
  4. [Section 2.2, Eq. (13)] The rotational broadening kernel in Eq. (13) appears to differ from the standard Díaz et al. (2011) kernel in the relative weight of the limb-darkening term: the second term, (π/2) ε arg, is larger by a factor of π compared with the usual expression when placed over the same denominator. Because the kernel normalization is performed 'ex-post' after Eq. (13), a shape error would not be caught by normalization. Please verify the formula against the cited source and add a numerical check of the kernel shape, for example, by comparing the resulting broadening profile with a direct convolution for a known rotation velocity.
minor comments (6)
  1. [Abstract] The abstract states that 'other effects (e.g., eclipses) are treated self-consistently,' but §3.3 acknowledges that the limb-darkening treatment is not self-consistent. Consider rewording to avoid overclaiming, e.g., 'eclipses are treated geometrically self-consistently.'
  2. [Section 2.1, Eq. (6)] The notation I_pass,i and I''_λ,i is confusing because both look like intensities. Please define I_pass,i explicitly as a passband weight (with units) and state that it is used only to weight the normalized spectra, not as a spectrum itself.
  3. [Figures 6 and 7] The captions of Figs. 6 and 7 do not label the rotation periods or the phases of the eclipse in the panels; the reader must infer the correspondence from the text. Please add explicit panel labels (e.g., 'P = 0.16 d' and 'φ = 0.02').
  4. [Figure 8] In Fig. 8, the top-right panel ('low resolution, fine sampling') and the bottom panels show wave-like artifacts, but the caption does not state the number of triangles used in each panel. Adding the triangle count and sampling step in each panel would make the convergence discussion clearer.
  5. [Section 2.3] Fig. 1 shows gaps in grid coverage, and the text mentions that Ndpolator uses nearest-neighbor extrapolation for safety. It would be useful to add a short warning that extrapolating to Teff or log g outside the grid boundaries is not a substitute for missing grid points and may produce unphysical spectra.
  6. [Section 3.2] The comparison with Gueymard (2003) is only qualitative. A residual plot or a brief statement of the rms difference over the plotted wavelength range would make the agreement more concrete.

Circularity Check

0 steps flagged · score 0.0 of 10

No significant circularity: the spectroscopic module is a forward model built on external literature grids, and the acknowledged limb-darkening approximation is a limitation, not a circular step.

full rationale

The paper contains no derivation chain in which a predicted quantity reduces by construction to a fitted input or to a self-citation. The complex model (Eq. 6) and the SED model (Eq. 8) integrate synthetic spectra obtained from external grids (PHOENIX, OSTAR, BSTAR, AMBRE, POLLUX, POWR) over triangular surface meshes; the spectra are parameterized by Teff, log g, and Z only, and the Doppler shifts and visibility fractions are computed geometrically. No parameter is fitted to the outputs shown in Figures 2-7. The only deliberately approximate element is the analytical limb-darkening law applied to spectra computed at mu=1. The paper explicitly concedes this is 'not self-consistent' (Section 3.3) and describes it as a compromise given the size of full mu-dependent grids. That is an acknowledged approximation and a possible source of systematic error for eclipse line profiles and absolute fluxes, but it is not circular: the analytical LD coefficients are user inputs, not quantities derived from or fitted to the spectra being predicted. The solar flux calibration in Section 3.2 is an external benchmark against measured solar irradiance and an independent synthetic solar spectrum (Gueymard 2003), not a round-trip of the module's own outputs. Citations to prior Phoebe papers (Prsa et al. 2016; Horvat et al. 2018; Conroy et al. 2020) are normal references to the underlying mesh and light-curve machinery; they do not carry the burden of proving the spectroscopic module's claims. The absence of validation against observed binary spectra is a limitation of external validity, not evidence of circularity. The central methodology is self-contained: literature spectra + geometric surface integration + Doppler shifting, with all approximations stated.

Assumptions & free parameters 0 free parameters · 4 assumptions · 0 invented entities

No free parameters are fit in this paper; the module uses external grid spectra and user-chosen limb-darkening coefficients. The main axioms are the accuracy of the external grids and the analytical limb-darkening approximation.

assumptions (4)
  • ad hoc to paper Analytical limb-darkening law with user-specified coefficients adequately represents the limb darkening of the underlying synthetic spectra.
    Stated in Section 2.1: since the grids only provide spectra for μ=1, the authors impose an analytical limb-darkening law; they admit it is not self-consistent.
  • domain assumption The synthetic spectrum grids (OSTAR, BSTAR, AMBRE, POLLUX, PHOENIX, POWR) from the literature are accurate and complete for the parameter ranges of interest.
    Used throughout; the module relies on external grids without independent validation in this paper.
  • domain assumption Linear interpolation (Ndpolator) between grid points yields sufficiently accurate spectra.
    Section 2.3: linear interpolation in n-dimensional space is used; extrapolation is nearest-neighbor.
  • standard math The Doppler shift can be applied per triangle as a simple radial velocity shift, ignoring other relativistic effects.
    Eq. (4) uses the non-relativistic Doppler formula, standard for such velocities.

how reviews work

0 comments
Cite this review

Pith. "Pith review of Physics Of Eclipsing Binaries. IX. Spectroscopic module." pith.science (2026). https://pith.science/paper/32555IF4

@misc{pith2026250620868,
  author       = {Pith},
  title        = {Pith review of: Physics Of Eclipsing Binaries. IX. Spectroscopic module},
  year         = {2026},
  howpublished = {\url{https://pith.science/paper/32555IF4}},
  note         = {Machine review of arXiv:2506.20868}
}
abstract

Spectroscopic observations constrain the fundamental properties of stellar atmospheres, in particular, the effective temperature, the gravitational acceleration, or the metallicity. In this work, we describe the spectroscopic module for Phoebe, which allows for modelling of spectra, either normalized, or in absolute units (${\rm W}\,{\rm m}^{-2}\,{\rm m}^{-1}$). The module is based on extensive grids of synthetic spectra, taken from literature, which are interpolated and integrated over the surface. As an approximation, we assume that limb darkening is given by an analytical law, while other effects (e.g., eclipses) are treated self-consistently. Our approach is suitable for single stars, binaries, or multiples, and can be further extended to systems with pulsating components. This draft refers to a development version of Phoebe, available at https://github.com/miroslavbroz/phoebe2/tree/spectroscopy2 . It is not yet included in the official Phoebe repository!

Figures

Figures reproduced from arXiv: 2506.20868 by the authors.

Figure 1
Figure 1. Coverage of the existing grids of normalized synthetic spectra, in terms of the effective temperature Teff vs. the gravitational acceleration log g. The metallicity Z is solar. creates spurious numerical noise, or ’wavy’ artifacts. On the other hand, if the observed resolution is low, one may optionally apply additional instrumental or rotational broadening of synthetic spectra during fitting, which, however, makes … view at source ↗
Figure 2
Figure 2. Basic example of the normalized flux Φλ over the wavelength λ (in angtr¨oms), computed for the default binary in Phoebe (i.e., P = 1 d, a = 5.3 R⊙, m1 = m2 .= 0.998813 M⊙, R1 = R2 = 1 R⊙, T1 = T2 = 6000 K, log g1 = log g2 .= 4.437). At the phase 0.25, the lines of components are shifted by the radial velocity amplitudes, K1 = K2 .= 134 km s−1 , as indicated by the red arrow. The original, unrotated synthetic spectru… view at source ↗
Figure 3
Figure 3. Same as [PITH_FULL_IMAGE:figures/full_fig_p006_3.png] view at source ↗
Figures from the paper (5 more)
Figure 4
Figure 4. Figure 4: Flux calibration example computed for the Sun at 1 au distance. The peak monochromatic flux Φλ .= 2 × 10−9 W m−2 m−1 is correct. For comparison, we plot the synthetic solar spectrum from Gueymard (2003) (black) and the Planck function (gray) for the effective temperatu…
Figure 5
Figure 5. Figure 5: Limb-darkening example computed for the default star in Phoebe (i.e., m = 1 M⊙, R = 1 R⊙); observed at a distance of 100 pc. Limb darkening coefficients were set to manual, linear; the values 0.0, 0.1, 0.2, 0.5, 1.0 were tested. The SED changes as expected. 0.2 0.3 0.4…
Figure 6
Figure 6. Figure 6: Rotation example computed for the default star in Phoebe. The rotation period values 0.16 (close to critical), 0.20, 0.30, 0.50, and >99 days were tested. The spectral lines change as expected. Hainich, R., Ramachandran, V., Shenar, T., Sander, A. A. C., Todt, H., Grun…
Figure 7
Figure 7. Figure 7: Eclipse example computed for the default binary in Phoebe. Left: Meshes with the fractions of triangles, which are visible. Right: Normalized synthetic normalized spectra Φλ (orange) over the wavelength λ. During the eclipse, line profiles of the components are blended…
Figure 8
Figure 8. Figure 8: Synthetic spectra for non-optimal sampling of λ or mesh resolution. Top left: If the resolution is high (2000 triangles per component), but the sampling is too coarse (0.1 ˚A), spectra of individual triangles with narrow lines are poorly sampled, but the resulting inte…

Discussion (0). Continue with ORCID to comment.

Reference graph

Works this paper leans on

31 extracted references · 19 canonical work pages

  1. [1]

    , " * write output.state after.block = add.period write newline

    ENTRY address author booktitle chapter edition editor howpublished institution journal key month note number organization pages publisher school series title type volume year label extra.label sort.label short.list INTEGERS output.state before.all mid.sentence after.sentence after.block FUNCTION init.state.consts #0 'before.all := #1 'mid.sentence := #2 '...

  2. [2]

    write newline

    " write newline "" before.all 'output.state := FUNCTION n.dashify 't := "" t empty not t #1 #1 substring "-" = t #1 #2 substring "--" = not "--" * t #2 global.max substring 't := t #1 #1 substring "-" = "-" * t #2 global.max substring 't := while if t #1 #1 substring * t #2 global.max substring 't := if while FUNCTION word.in bbl.in " " * FUNCTION format....

  3. [3]

    2023, , 669, L11

    Abdul-Masih , M. 2023, , 669, L11

    work page 2023

  4. [4]

    E., Sundqvist , J., Pr s a , A., Kochoska , A., & Puls , J

    Abdul-Masih , M., Sana , H., Conroy , K. E., Sundqvist , J., Pr s a , A., Kochoska , A., & Puls , J. 2020, , 636, A59

    work page 2020

  5. [5]

    Aerts , C., Christensen-Dalsgaard , J., & Kurtz , D. W. 2010, Asteroseismology (Springer Science+Business Media B.V.)

    work page 2010

  6. [6]

    2023, arXiv e-prints, arXiv:2311.08453

    Aerts , C., & Tkachenko , A. 2023, arXiv e-prints, arXiv:2311.08453

    arXiv 2023

  7. [7]

    P., et al

    Aufdenberg , J. P., et al. 2006, , 645, 664

    work page 2006

  8. [8]

    2017, , 230, 19

    Bro z , M. 2017, , 230, 19

    2017

Show all 31 references
  1. [9]

    E., et al

    Conroy , K. E., et al. 2020, , 250, 34

    2020

  2. [10]

    C., & Plez , B

    de Laverny , P., Recio-Blanco , A., Worley , C. C., & Plez , B. 2012, , 544, A126

    2012

  3. [11]

    G., Gonz \'a lez , J

    D \' az , C. G., Gonz \'a lez , J. F., Levato , H., & Grosso , M. 2011, , 531, A143

    2011

  4. [12]

    Gueymard , C. A. 2003, Solar Energy, 74, 355

    2003

  5. [13]

    Hainich , R., Ramachandran , V., Shenar , T., Sander , A. A. C., Todt , H., Gruner , D., Oskinova , L. M., & Hamann , W. R. 2019, , 621, A85

    2019

  6. [14]

    E., Pablo , H., Hambleton , K

    Horvat , M., Conroy , K. E., Pablo , H., Hambleton , K. M., Kochoska , A., Giammarco , J., & Pr s a , A. 2018, , 237, 26

    2018

  7. [15]

    O., Wende-von Berg , S., Dreizler , S., Homeier , D., Reiners , A., Barman , T., & Hauschildt , P

    Husser , T. O., Wende-von Berg , S., Dreizler , S., Homeier , D., Reiners , A., Barman , T., & Hauschildt , P. H. 2013, , 553, A6

    2013

  8. [16]

    2020, , 247, 63

    Jones , D., et al. 2020, , 247, 63

    2020

  9. [17]

    2020, , 160, 120

    J \"o nsson , H., et al. 2020, , 160, 120

    2020

  10. [18]

    1959, Close binary systems (The International Astrophysics Series, London: Chapman & Hall)

    Kopal , Z. 1959, Close binary systems (The International Astrophysics Series, London: Chapman & Hall)

    1959

  11. [19]

    Kopp , G., & Lean , J. L. 2011, , 38, L01706

    2011

  12. [20]

    2003, , 146, 417

    Lanz , T., & Huben\' y , I. 2003, , 146, 417

    2003

  13. [21]

    2007, , 169, 83

    ---. 2007, , 169, 83

    2007

  14. [22]

    Maintz , M., Rivinius , T., S tefl , S., Baade , D., Wolf , B., & Townsend , R. H. D. 2003, , 411, 181

    2003

  15. [23]

    A., et al

    Nemravov \'a , J. A., et al. 2016, , 594, A55

    2016

  16. [24]

    2010, , 516, A13

    Palacios , A., Gebran , M., Josselin , E., Martins , F., Plez , B., Belmas , M., & L \`e bre , A. 2010, , 516, A13

    2010

  17. [25]

    2016, , 227, 29

    Pr s a , A., et al. 2016, , 227, 29

    2016

  18. [26]

    A., Venero , R., Repolust , T., Springmann , U., Jokuthy , A., & Mokiem , M

    Puls , J., Urbaneja , M. A., Venero , R., Repolust , T., Springmann , U., Jokuthy , A., & Mokiem , M. R. 2005, , 435, 669

    2005

  19. [27]

    1873, d'Essai sur la constitution et l'origine du système solaire (Montpellier: Boehm et fils)

    Roche , \' E . 1873, d'Essai sur la constitution et l'origine du système solaire (Montpellier: Boehm et fils)

  20. [28]

    G., et al

    Sacco , G. G., et al. 2014, , 565, A113

    2014

  21. [29]

    2012, , 746, 85

    Suzuki , N., et al. 2012, , 746, 85

    2012

  22. [30]

    1924, , 84, 665

    von Zeipel , H. 1924, , 84, 665

    1924

  23. [31]

    C., de Laverny , P., Recio-Blanco , A., Hill , V., Bijaoui , A., & Ordenovic , C

    Worley , C. C., de Laverny , P., Recio-Blanco , A., Hill , V., Bijaoui , A., & Ordenovic , C. 2012, , 542, A48

    2012

Pith tools

Reviewed August 6, 2026 · model on record in the stance chip above.